linux-kernel - Re: [ghes_copy_tofrom_phys] BUG: sleeping function called from invalid context at mm/page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171030145631.xnv5ph6uyfc6uvqb@pd.tnic>
Date:   Mon, 30 Oct 2017 15:56:36 +0100
From:   Borislav Petkov <bp@...e.de>
To:     Tyler Baicar <tbaicar@...eaurora.org>
Cc:     Fengguang Wu <fengguang.wu@...el.com>,
        Huang Ying <ying.huang@...el.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Will Deacon <will.deacon@....com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>
Subject: Re: [ghes_copy_tofrom_phys] BUG: sleeping function called from
 invalid context at mm/page_alloc.c:4150

On Mon, Oct 30, 2017 at 10:17:27AM -0400, Tyler Baicar wrote:
> I'm okay with reverting this

Then please send a revert patch along with a cleaned up splat explaining why
we're reverting.

> and coming up with another solution, but that seems like it could be
> masking a problem.

Doh, the splat already told you what the problem is:

[   49.311408] BUG: sleeping function called from invalid context at mm/page_alloc.c:4150

you simply can't sleep in atomic context. GHES code better adhere to
that.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--