linux-kernel - Re: [PATCH v2] workqueue: Fix NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171030145936.GC3252168@devbig577.frc2.facebook.com>
Date:   Mon, 30 Oct 2017 07:59:36 -0700
From:   Tejun Heo <tj@...nel.org>
To:     Li Bin <huawei.libin@...wei.com>
Cc:     Lai Jiangshan <jiangshanlai@...il.com>,
        linux-kernel@...r.kernel.org, tanxiaofei@...wei.com,
        guohanjun@...wei.com
Subject: Re: [PATCH v2] workqueue: Fix NULL pointer dereference

On Sat, Oct 28, 2017 at 11:07:28AM +0800, Li Bin wrote:
> When queue_work() is used in irq (not in task context), there is
> a potential case that trigger NULL pointer dereference.
> ----------------------------------------------------------------
> worker_thread()
> |-spin_lock_irq()
> |-process_one_work()
> 	|-worker->current_pwq = pwq
> 	|-spin_unlock_irq()
> 	|-worker->current_func(work)
> 	|-spin_lock_irq()
>  	|-worker->current_pwq = NULL
> |-spin_unlock_irq()
> 
> 				//interrupt here
> 				|-irq_handler
> 					|-__queue_work()
> 						//assuming that the wq is draining
> 						|-is_chained_work(wq)
> 							|-current_wq_worker()
> 							//Here, 'current' is the interrupted worker!
> 								|-current->current_pwq is NULL here!
> |-schedule()
> ----------------------------------------------------------------
> 
> Avoid it by checking for task context in current_wq_worker(), and
> if not in task context, we shouldn't use the 'current' to check the
> condition.
> 
> Reported-by: Xiaofei Tan <tanxiaofei@...wei.com>
> Signed-off-by: Li Bin <huawei.libin@...wei.com>

Applied to wq/for-4.14-fixes w/ -stable cc'd.

Thanks.

-- 
tejun