linux-kernel - RE: [PATCH v10 6/9] LPC: Support the LPC host on Hip06/Hip07 with DT bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <EE11001F9E5DDD47B7634E2F8A612F2E40CAEE3A@FRAEML521-MBX.china.huawei.com>
Date:   Mon, 30 Oct 2017 15:55:15 +0000
From:   Gabriele Paoloni <gabriele.paoloni@...wei.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will.deacon@....com" <will.deacon@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "frowand.list@...il.com" <frowand.list@...il.com>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>
CC:     "mark.rutland@....com" <mark.rutland@....com>,
        "brian.starkey@....com" <brian.starkey@....com>,
        "olof@...om.net" <olof@...om.net>,
        "benh@...nel.crashing.org" <benh@...nel.crashing.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        Linuxarm <linuxarm@...wei.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "minyard@....org" <minyard@....org>,
        John Garry <john.garry@...wei.com>,
        "xuwei (O)" <xuwei5@...ilicon.com>,
        "zhichang.yuan" <yuanzhichang@...ilicon.com>
Subject: RE: [PATCH v10 6/9] LPC: Support the LPC host on Hip06/Hip07 with
 DT bindings

Hi Randy

> -----Original Message-----
> From: Randy Dunlap [mailto:rdunlap@...radead.org]
> Sent: 27 October 2017 17:44
> To: Gabriele Paoloni; catalin.marinas@....com; will.deacon@....com;
> robh+dt@...nel.org; frowand.list@...il.com; bhelgaas@...gle.com;
> rafael@...nel.org; arnd@...db.de; linux-arm-kernel@...ts.infradead.org;
> lorenzo.pieralisi@....com
> Cc: mark.rutland@....com; brian.starkey@....com; olof@...om.net;
> benh@...nel.crashing.org; linux-kernel@...r.kernel.org; linux-
> acpi@...r.kernel.org; Linuxarm; linux-pci@...r.kernel.org;
> minyard@....org; John Garry; xuwei (O); zhichang.yuan
> Subject: Re: [PATCH v10 6/9] LPC: Support the LPC host on Hip06/Hip07
> with DT bindings
> 
> On 10/27/17 09:11, Gabriele Paoloni wrote:
> > diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> > index 2408ea3..358eed3 100644
> > --- a/drivers/bus/Kconfig
> > +++ b/drivers/bus/Kconfig
> > @@ -64,6 +64,15 @@ config BRCMSTB_GISB_ARB
> >  	  arbiter. This driver provides timeout and target abort error
> handling
> >  	  and internal bus master decoding.
> >
> > +config HISILICON_LPC
> > +	bool "Support for ISA I/O space on Hisilicon Hip0X"
> > +	depends on (ARM64 && (ARCH_HISI || COMPILE_TEST))
> > +	select LOGIC_PIO
> > +	select INDIRECT_PIO
> > +	help
> > +	  Driver needed for some legacy ISA devices attached to Low-Pin-
> Count
> > +	  on Hisilicon Hip0X SoC.
> > +
> >  config IMX_WEIM
> >  	bool "Freescale EIM DRIVER"
> >  	depends on ARCH_MXC
> 
> Hi,
> 
> Why bool? why not tristate?

Well for the nature of our HW it would not make much sense to have the
LPC modular. Also you can see in patch 8 the LPC host is "translating"
the resources of its children before these are actually probed and this
is done by acpi_indirectio_scan_init() as part of the ACPI init process.

Thanks
Gab

> 
> --
> ~Randy