linux-kernel - Re: [PATCH] ARM: add a private asm/unaligned.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171030161207.GS20805@n2100.armlinux.org.uk>
Date:   Mon, 30 Oct 2017 16:12:08 +0000
From:   Russell King - ARM Linux <linux@...linux.org.uk>
To:     Gregory CLEMENT <gregory.clement@...e-electrons.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Romain Izard <romain.izard.pro@...il.com>,
        Sven Schmidt <4sschmid@...ormatik.uni-hamburg.de>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-arm-kernel@...ts.infradead.org,
        Petr Cvek <petrcvekcz@...il.com>,
        Aaro Koskinen <aaro.koskinen@....fi>,
        Andrea Adami <andrea.adami@...il.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>
Subject: Re: [PATCH] ARM: add a private asm/unaligned.h

On Mon, Oct 30, 2017 at 05:01:44PM +0100, Gregory CLEMENT wrote:
> Hi Russell King,
>  
>  On lun., oct. 30 2017, Russell King - ARM Linux <linux@...linux.org.uk> wrote:
> 
> > On Mon, Oct 30, 2017 at 02:48:02PM +0100, Gregory CLEMENT wrote:
> >> Hi Russell,
> >> 
> >> So I tested the branch fixes in your git tree.
> >> 
> >> After doing a "make multi_v7_defconfig; make zImage", I got the message
> >> "arm-linux-gnueabi-ld: error: zImage file size is incorrect" you added
> >> in the commit "ARM: verify size of zImage".
> >> 
> >> It is the same with mvebu_v7_defconfig, so I wonder wich with
> >> configuration this patch was tested ?
> >
> > I heard a similar report from Olof when his autobuilder produced 100%
> > failure.  I tried one of the same defconfig's that Olof tried here,
> > and didn't see the failure.  It passes my build tests here, and it
> > also passes kernelci's build tests too.
> >
> > So, I _think_ it's got something to do with the toolchain versions
> > being used, but at the moment I'm just guessing.  I've no real idea,
> > because I've no idea what's causing the failure at the moment.
> >
> > Olof said that he'd send me one of the build trees, but I'm still
> > waiting.
> >
> > What I need is a tarball of the objects from arch/arm/boot/compressed
> > to work out what's going on - when grabbing that, it may be a good
> 
> I've just attached this tarball to this email. It might be rejected by
> the mailing list, but as you are also in the "To" field you should
> receive it.
> 
> Actually the archive is the full content of arch/arm/boot/compressed
> from my build directory and I removed vmlinux and all the piggy files to
> have a small archive.
> 
> If they are also needed then I can provide an url for it.

Thanks.

Unfortunately, I can't reproduce the issue using your objects and my
linker.

If I modify your vmlinux.lds to add the assert in, and then link using:

$ arm-linux-ld -o vmlinux -T vmlinux.lds *.o --defsym _kernel_bss_size=0 \
  --defsym input_data_end=0 --defsym input_data=0

Then it links successfully.  If I objcopy that:

$ arm-linux-objcopy -O binary -R .comment -S vmlinux zImage
$ vdir zImage
-rwxrwxr-x 1 rmk rmk 27784 Oct 30 16:10 zImage
$ arm-linux-nm vmlinux |grep _edata
00006c88 D _edata
$ echo $((0x6c88))
27784

So it all looks sane here.  So my hunch is that whatever's going wrong,
it's going wrong at the final link, which means I need the vmlinux as
generated by your toolchain.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up