linux-kernel - Re: [PATCH] sched/sysctl: Fix attributes of some extern declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171030174253.d74aowcgetph5vq4@hirez.programming.kicks-ass.net>
Date:   Mon, 30 Oct 2017 18:42:53 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Shile Zhang <shile.zhang@...ia.com>,
        linux-kernel@...r.kernel.org,
        Nick Desaulniers <nick.desaulniers@...il.com>,
        Douglas Anderson <dianders@...omium.org>,
        Guenter Roeck <groeck@...omium.org>
Subject: Re: [PATCH] sched/sysctl: Fix attributes of some extern declarations

On Mon, Oct 30, 2017 at 10:27:10AM -0700, Matthias Kaehlcke wrote:
> El Mon, Oct 30, 2017 at 09:26:12AM +0100 Peter Zijlstra ha dit:
> 
> > On Fri, Oct 27, 2017 at 04:40:20PM -0700, Matthias Kaehlcke wrote:
> > > The definition of sysctl_sched_migration_cost, sysctl_sched_nr_migrate
> > > and sysctl_sched_time_avg includes the attribute const_debug. This
> > > attribute is not part of the extern declaration of these variables in
> > > include/linux/sched/sysctl.h, as a result clang generates warnings like
> > > this:
> > > 
> > >   kernel/sched/sched.h:1618:33: warning: section attribute is specified on
> > >     redeclared variable [-Wsection]
> > >   extern const_debug unsigned int sysctl_sched_time_avg;
> > 
> > Since they're already declared in sched/sysctl.h this redeclaration in
> > sched/sched.h seems pointless.
> 
> We could remove it, but it would require to move the definition of
> const_debug to the 'globally' visible header sched/sysctl.h. Would
> that be your preference? In that case we should probably use a more
> unique name, like const_sched_debug.

Ah, I see; I got lost in the #ifdef maze. Yes you're right. Keep it like
it is then.