linux-kernel - Re: [PATCH v2] bcache: explicitly destroy mutex while exiting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a8c68129-9b7f-66c0-d7ee-ea56b236a933@lyle.org>
Date:   Mon, 30 Oct 2017 11:02:27 -0700
From:   Michael Lyle <mlyle@...e.org>
To:     Liang C <liangchen.linux@...il.com>
Cc:     Coly Li <i@...y.li>, linux-bcache@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] bcache: explicitly destroy mutex while exiting

Hi Liang--

On 10/30/2017 05:33 AM, Liang C wrote:
> Hi Michael,
> Would you please to include this patch in your tree for the next
> release? It seems passed the review. Thank you.
> 
> Thanks,
> Liang

Thanks for the reminder.

It's in my bcache-for-next tree at https://github.com/mlyle/linux/ along
with a few other small changes.  I am testing today and plan on sending
them up to Jens soon if I have good luck overall (and after reading
overall diff).

Though: it is getting late for non-critical changes in 4.15 so I need to
have perfect test sequences with no unexplained anomalies to send these
to Jens for 4.15.

Mike

> 
> On Tue, Oct 10, 2017 at 11:44 PM, Michael Lyle <mlyle@...e.org> wrote:
>> On 10/10/2017 05:25 AM, Coly Li wrote:
>>> On 2017/10/10 下午5:00, Liang Chen wrote:
>>>> mutex_destroy does nothing most of time, but it's better to call
>>>> it to make the code future proof and it also has some meaning
>>>> for like mutex debug.
>>>>
>>>> As Coly pointed out in a previous review, bcache_exit() may not be
>>>> able to handle all the references properly if userspace registers
>>>> cache and backing devices right before bch_debug_init runs and
>>>> bch_debug_init failes later. So not exposing userspace interface
>>>> until everything is ready to avoid that issue.
>>>>
>>>> Signed-off-by: Liang Chen <liangchen.linux@...il.com>
>>>
>>> Hi Liang,
>>>
>>> No more comment from me, it looks good. Thanks.
>>>
>>> Reviewed-by: Coly Li <colyli@...e.de>
>>
>> Looks good to me too.
>>
>> Reviewed-by: Michael Lyle <mlyle@...e.org>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>