linux-kernel - Re: [RESEND][PATCH 0/3] module: Do not paper over type mismatches in module_param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jJWujShMJ4MM8bOyPrtDUTcfjH1_xufCWdbwS1hnb0Zsg@mail.gmail.com>
Date:   Mon, 30 Oct 2017 14:20:06 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Jessica Yu <jeyu@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND][PATCH 0/3] module: Do not paper over type mismatches in module_param_call()

On Tue, Oct 17, 2017 at 7:04 PM, Kees Cook <keescook@...omium.org> wrote:
> (re-sending to Jessica's @korg address...)
>
> The module_param_call() macro was explicitly casting the .set and .get
> function prototypes away with (void *). This can lead to hard-to-find
> type mismatches. Additionally, it creates problems for static checkers
> and Control Flow Itegrity compiler features, which depend on clustering
> function call sites based on prototype signature.
>
> This removes the casts and fixes all the incorrect prototypes tree-wide.

A quick ping on this. I'd really like to land this in 4.15, as it's
relatively trivial. How does this look to you Jessica?

-Kees

-- 
Kees Cook
Pixel Security