linux-kernel - Re: [PATCH] usb: musb: dsps: remove the duplicated timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171030214415.GB10043@kroah.com>
Date:   Mon, 30 Oct 2017 22:44:15 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Bin Liu <b-liu@...com>, linux-usb@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: musb: dsps: remove the duplicated timer

On Mon, Oct 30, 2017 at 02:29:54PM -0700, Kees Cook wrote:
> On Mon, Oct 30, 2017 at 9:29 AM, Bin Liu <b-liu@...com> wrote:
> > Now struct musb has the timer (dev_timer) for glue drivers, so let's
> > remove the duplicated timer defined in dsps glue driver, and use
> > dev_timer defined in struct musb.
> >
> > Signed-off-by: Bin Liu <b-liu@...com>
> 
> Reviewed-by: Kees Cook <keescook@...omium.org>
> 
> Thanks for this; it wasn't clear to me if both timers needed to exist
> (i.e. glue operated independently from the musb object), so I didn't
> make this change myself.
> 
> Greg, it probably makes sense to just take both patches. Does that work for you?

Yes, I can do that, thanks.

greg k-h