linux-kernel - Re: [Jfs-discussion] [PATCH] jfs: remove increment of i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <afce5b26-020a-f469-3fb3-84770244f264@oracle.com>
Date:   Mon, 30 Oct 2017 17:22:33 -0500
From:   Dave Kleikamp <dave.kleikamp@...cle.com>
To:     Jeff Layton <jlayton@...nel.org>
Cc:     linux-fsdevel@...r.kernel.org,
        jfs-discussion@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [Jfs-discussion] [PATCH] jfs: remove increment of i_version
 counter

On 10/30/2017 10:16 AM, Jeff Layton wrote:
> From: Jeff Layton <jlayton@...hat.com>
> 
> JFS does not set SB_I_VERSION and doesn't use the i_version counter
> internally. Just remove this increment.

Looks good. I'll push it upstream.

Thanks,
Shaggy

> 
> Signed-off-by: Jeff Layton <jlayton@...hat.com>
> ---
>  fs/jfs/super.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/jfs/super.c b/fs/jfs/super.c
> index 2f14677169c3..2f7b3af5b8b7 100644
> --- a/fs/jfs/super.c
> +++ b/fs/jfs/super.c
> @@ -853,7 +853,6 @@ static ssize_t jfs_quota_write(struct super_block *sb, int type,
>  	}
>  	if (inode->i_size < off+len-towrite)
>  		i_size_write(inode, off+len-towrite);
> -	inode->i_version++;
>  	inode->i_mtime = inode->i_ctime = current_time(inode);
>  	mark_inode_dirty(inode);
>  	inode_unlock(inode);
>