linux-kernel - Re: [PATCH] crypto: testmgr: don't allocate IV on stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171031075925.GA26147@gondor.apana.org.au>
Date:   Tue, 31 Oct 2017 15:59:25 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Gilad Ben-Yossef <gilad@...yossef.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Ofir Drang <ofir.drang@....com>, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: testmgr: don't allocate IV on stack

On Tue, Oct 31, 2017 at 07:56:26AM +0000, Gilad Ben-Yossef wrote:
> The IV was allocated on the stack in testmgr skcipher tests.
> Since HW based tfm providers need to DMA the IV to the HW,
> this leads to problems and is detected by the DMA-API debug
> code.
> 
> Fix it by allocating the IV using kmalloc instead.
> 
> Signed-off-by: Gilad Ben-Yossef <gilad@...yossef.com>

The driver that is mapping the IV directly should be fixed instead.
Only input that is given in the form of SG lists can be mapped.
Everything else should be copied if they need to go over DMA.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt