linux-kernel - Re: [PATCH v2 4/7] gpio: brcmstb: switch to handle_level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYFTi4qspSP_2YL6_GP5DSm5RvjyX9arx4pPy0mhG+Wkg@mail.gmail.com>
Date:   Tue, 31 Oct 2017 10:30:20 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Doug Berger <opendmb@...il.com>
Cc:     Gregory Fong <gregory.0xf0@...il.com>,
        Brian Norris <computersforpeace@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 4/7] gpio: brcmstb: switch to handle_level_irq flow

On Tue, Oct 24, 2017 at 9:54 PM, Doug Berger <opendmb@...il.com> wrote:

> Reading and writing the gpio bank status register each time a pending
> interrupt bit is serviced could cause new pending bits to be cleared
> without servicing the associated interrupts.
>
> By using the handle_level_irq flow instead of the handle_simple_irq
> flow we get proper handling of interrupt masking as well as acking
> of interrupts.  The irq_ack method is added to support this.
>
> Fixes: 19a7b6940b78 ("gpio: brcmstb: Add interrupt and wakeup source support")
> Signed-off-by: Doug Berger <opendmb@...il.com>
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> Acked-by: Gregory Fong <gregory.0xf0@...il.com>

Patch applied.

Yours,
Linus Walleij