linux-kernel - Re: [PATCH v3 0/12] arm+arm64: vdso unification to lib/vdso/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171031094953.GA5584@arm.com>
Date:   Tue, 31 Oct 2017 09:49:53 +0000
From:   Will Deacon <will.deacon@....com>
To:     Mark Rutland <mark.rutland@....com>
Cc:     Mark Salyzyn <salyzyn@...roid.com>, linux-kernel@...r.kernel.org,
        James Morse <james.morse@....com>,
        Russell King <linux@...linux.org.uk>,
        Catalin Marinas <catalin.marinas@....com>,
        Andy Lutomirski <luto@...capital.net>,
        Dmitry Safonov <dsafonov@...tuozzo.com>,
        John Stultz <john.stultz@...aro.org>,
        Laura Abbott <labbott@...hat.com>,
        Kees Cook <keescook@...omium.org>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Andy Gross <andy.gross@...aro.org>,
        Kevin Brodsky <kevin.brodsky@....com>,
        Andrew Pinski <apinski@...ium.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 0/12] arm+arm64: vdso unification to lib/vdso/

On Mon, Oct 30, 2017 at 09:44:35PM +0000, Mark Rutland wrote:
> On Mon, Oct 30, 2017 at 01:34:13PM -0700, Mark Salyzyn wrote:
> > On 10/30/2017 07:18 AM, Mark Rutland wrote:
> > > On Fri, Oct 27, 2017 at 03:23:48PM -0700, Mark Salyzyn wrote:
> > > > Note I noticed a bug in the old implementation of __kernel_clock_getres;
> > > > it was checking only the lower 32bits of the pointer; this would work
> > > > for most cases but could fail in a few.
> > > Sorry if this is a stupid question, but do you mean from a prior version
> > > of this series, or the one in the kernel today?
> > 
> > apinski@...ium.com noticed this as part of the existing upstream arm64
> > assembler when he did the original conversion to C.
> 
> Just to check, does the below address the issue, or is there something that
> I've missed?

Looks fine to me. Applied.

Will