linux-kernel - Re: [PATCH] crypto: testmgr: don't allocate IV on stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171031101908.GA26530@gondor.apana.org.au>
Date:   Tue, 31 Oct 2017 18:19:08 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Horia Geantă <horia.geanta@....com>
Cc:     Gilad Ben-Yossef <gilad@...yossef.com>,
        "David S. Miller" <davem@...emloft.net>,
        Ofir Drang <ofir.drang@....com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto: testmgr: don't allocate IV on stack

On Tue, Oct 31, 2017 at 09:05:57AM +0000, Horia Geantă wrote:
> > 
> > The driver that is mapping the IV directly should be fixed instead.
> > Only input that is given in the form of SG lists can be mapped.
> > Everything else should be copied if they need to go over DMA.
> > 
> Herbert, wouldn't it make more sense to follow your previous suggestion:
> "Perhaps we should change the API so that it gets passed in as an
> SG list."
> https://www.mail-archive.com/linux-crypto@vger.kernel.org/msg23082.html

Unless someone is willing to work on that then we have to fix the
drivers to fit the current API.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt