linux-kernel - Re: [PATCH] kconfig: kill off GENERIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171031114433.14fcc904@bbrezillon>
Date:   Tue, 31 Oct 2017 11:44:33 +0100
From:   Boris Brezillon <boris.brezillon@...e-electrons.com>
To:     Rob Herring <robh@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Jeff Dike <jdike@...toit.com>,
        Richard Weinberger <richard@....at>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        user-mode-linux-devel@...ts.sourceforge.net,
        user-mode-linux-user@...ts.sourceforge.net,
        linux-mtd@...ts.infradead.org
Subject: Re: [PATCH] kconfig: kill off GENERIC_IO option

On Mon, 16 Oct 2017 17:16:31 -0500
Rob Herring <robh@...nel.org> wrote:

> The GENERIC_IO option is set for every architecture except tile and score
> as those define NO_IOMEM. The option only controls visibility of
> CONFIG_MTD which doesn't appear to be necessary for any reason, so let's
> just remove GENERIC_IO.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>
> Cc: Jeff Dike <jdike@...toit.com>
> Cc: Richard Weinberger <richard@....at>
> Cc: David Woodhouse <dwmw2@...radead.org>
> Cc: Brian Norris <computersforpeace@...il.com>
> Cc: Boris Brezillon <boris.brezillon@...e-electrons.com>

Acked-by: Boris Brezillon <boris.brezillon@...e-electrons.com>

> Cc: Marek Vasut <marek.vasut@...il.com>
> Cc: Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>
> Cc: user-mode-linux-devel@...ts.sourceforge.net
> Cc: user-mode-linux-user@...ts.sourceforge.net
> Cc: linux-mtd@...ts.infradead.org
> ---
>  arch/um/Kconfig.common | 1 -
>  drivers/mtd/Kconfig    | 1 -
>  lib/Kconfig            | 4 ----
>  3 files changed, 6 deletions(-)
> 
> diff --git a/arch/um/Kconfig.common b/arch/um/Kconfig.common
> index 85f6dd204ab6..5514ec52108f 100644
> --- a/arch/um/Kconfig.common
> +++ b/arch/um/Kconfig.common
> @@ -9,7 +9,6 @@ config UML
>  	select HAVE_DEBUG_KMEMLEAK
>  	select GENERIC_IRQ_SHOW
>  	select GENERIC_CPU_DEVICES
> -	select GENERIC_IO
>  	select GENERIC_CLOCKEVENTS
>  	select HAVE_GCC_PLUGINS
>  	select TTY # Needed for line.c
> diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
> index 5a2d71729b9a..2a8ac6829d42 100644
> --- a/drivers/mtd/Kconfig
> +++ b/drivers/mtd/Kconfig
> @@ -1,6 +1,5 @@
>  menuconfig MTD
>  	tristate "Memory Technology Device (MTD) support"
> -	depends on GENERIC_IO
>  	help
>  	  Memory Technology Devices are flash, RAM and similar chips, often
>  	  used for solid state file systems on embedded devices. This option
> diff --git a/lib/Kconfig b/lib/Kconfig
> index b1445b22a6de..994fa37a1d96 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -46,10 +46,6 @@ config GENERIC_IOMAP
>  	bool
>  	select GENERIC_PCI_IOMAP
>  
> -config GENERIC_IO
> -	bool
> -	default n
> -
>  config STMP_DEVICE
>  	bool
>