linux-kernel - [tip:irq/core] irq/work: Don't reinvent the wheel but use existing llist API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-16c0890dc66d258fdeccf7b15a133f3930b19143@git.kernel.org>
Date:   Tue, 31 Oct 2017 05:04:42 -0700
From:   tip-bot for Byungchul Park <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, frederic@...nel.org,
        byungchul.park@....com, peterz@...radead.org, tglx@...utronix.de,
        mingo@...nel.org, hpa@...or.com, torvalds@...ux-foundation.org
Subject: [tip:irq/core] irq/work: Don't reinvent the wheel but use existing
 llist API

Commit-ID:  16c0890dc66d258fdeccf7b15a133f3930b19143
Gitweb:     https://git.kernel.org/tip/16c0890dc66d258fdeccf7b15a133f3930b19143
Author:     Byungchul Park <byungchul.park@....com>
AuthorDate: Tue, 31 Oct 2017 02:46:54 +0100
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Tue, 31 Oct 2017 10:24:39 +0100

irq/work: Don't reinvent the wheel but use existing llist API

Use the proper llist APIs instead of open-coded variants of them.

Signed-off-by: Byungchul Park <byungchul.park@....com>
Signed-off-by: Frederic Weisbecker <frederic@...nel.org>
Acked-by: Thomas Gleixner <tglx@...utronix.de>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Link: http://lkml.kernel.org/r/1509414414-14987-1-git-send-email-frederic@kernel.org
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 kernel/irq_work.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/kernel/irq_work.c b/kernel/irq_work.c
index bcf107c..e2ebe8c 100644
--- a/kernel/irq_work.c
+++ b/kernel/irq_work.c
@@ -138,11 +138,7 @@ static void irq_work_run_list(struct llist_head *list)
 		return;
 
 	llnode = llist_del_all(list);
-	while (llnode != NULL) {
-		work = llist_entry(llnode, struct irq_work, llnode);
-
-		llnode = llist_next(llnode);
-
+	llist_for_each_entry(work, llnode, llnode) {
 		/*
 		 * Clear the PENDING bit, after this point the @work
 		 * can be re-used.