linux-kernel - Re: [PATCH v2] target/iscsi: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5j+z9t28n33e6r9hxRNX1hpkzF4Z5sy308sWYh84whkRfQ@mail.gmail.com>
Date:   Mon, 30 Oct 2017 17:04:48 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Bart Van Assche <Bart.VanAssche@....com>
Cc:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "varun@...lsio.com" <varun@...lsio.com>,
        "target-devel@...r.kernel.org" <target-devel@...r.kernel.org>,
        "jiangyilism@...il.com" <jiangyilism@...il.com>,
        "nab@...ux-iscsi.org" <nab@...ux-iscsi.org>
Subject: Re: [PATCH v2] target/iscsi: Convert timers to use timer_setup()

On Fri, Oct 27, 2017 at 5:57 AM, Bart Van Assche <Bart.VanAssche@....com> wrote:
> On Fri, 2017-10-27 at 02:19 -0700, Kees Cook wrote:
>> In preparation for unconditionally passing the struct timer_list pointer to
>> all timer callbacks, switch to using the new timer_setup() and from_timer()
>> to pass the timer pointer explicitly. Includes a fix for correcting an
>> on-stack timer usage.
>
> Hello Kees,
>
> These changes look good to me but I would like to test this patch. Is there
> a tree available somewhere that includes this patch?

I didn't, but in case it's easier to test, I have put it up here,
which is just tip/timers/core with the two target timer patches on
top:

https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=kspp/timer/tip/target

Thanks!

-Kees

-- 
Kees Cook
Pixel Security