linux-kernel - [RFC PATCH 0/2] scripts: warn about invalid MAINTAINER patterns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 31 Oct 2017 09:46:11 -0500
From:   Tom Saeger <tom.saeger@...cle.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Tom Saeger <tom.saeger@...cle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "David S. Miller" <davem@...emloft.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        linux-kernel@...r.kernel.org
Subject: [RFC PATCH 0/2] scripts: warn about invalid MAINTAINER patterns

This series attempts to fix all stale MAINTAINER file "F" and "X" patterns.

First patch adds an option "checks" to get_maintainer.pl which outputs
warnings for any "F" or "X" pattern found in MAINTAINER file which does
not register any file/directory matches known by git in current worktree.

Originally, I wrote a standalone script "check_maintainer", but as this
duplicated some of the functions found in get_maintainer.pl it seemed to
make more sense to change get_maintainer.pl directly.

The "-x|--checks" option is intended to be used as follows:

./scripts/get_maintainer.pl -x ./ | tee out.txt
./MAINTAINERS:1743      warning: no matches     drivers/.*/pm8...-.*    F:      drivers/*/pm8???-*
./MAINTAINERS:8721      warning: no matches     drivers/net/ethernet/mellanox/mlx5/core/en_ipsec/.*     F:      drivers/net/ethernet/mellanox/mlx5/core/en_ipsec/*
./MAINTAINERS:8722      warning: no matches     drivers/net/ethernet/mellanox/mlx5/core/ipsec.* F:      drivers/net/ethernet/mellanox/mlx5/core/ipsec*
./MAINTAINERS:9431      warning: no matches     net/core/flow\.c        F:      net/core/flow.c

The output format lends itself to the following in vim (note tab
character):
set errorformat=%f:%l\	%m
cfile out.txt
copen

Second patch fixes all MAINTAINER warnings but four (those listed above), which were not
obvious to me how to fix.  Most fixes were obvious, requiring only "ls
./**/*pat*" or "git log --follow -- xyz.c" or "git blame MAINTAINERS" to
figure out what needed to be changed.

Patches are independent, however I did employ the first in figuring out the
second.

Looking for input on how best to get these merged.  Some of these have
been broken for a long time - so stable kernels might benefit from
backporting.

Future enhancements could sanity check all the other entry types found in
MAINTAINER file.

--Tom

Tom Saeger (2):
  scripts: warn about invalid MAINTAINER patterns
  MAINTAINERS: various pattern fixes for mv/rm/typos

 MAINTAINERS               | 107 ++++++++++++++++++----------------------------
 scripts/get_maintainer.pl |  65 ++++++++++++++++++++++++++++
 2 files changed, 107 insertions(+), 65 deletions(-)

-- 
2.14.3