linux-kernel - Re: [PATCH] drm: gma500: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 31 Oct 2017 08:08:14 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Kees Cook <keescook@...omium.org>,
        Patrik Jakobsson <patrik.r.jakobsson@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] drm: gma500: Convert timers to use timer_setup()

On Tue, Oct 31, 2017 at 3:18 AM, Daniel Vetter <daniel@...ll.ch> wrote:
> On Mon, Oct 30, 2017 at 03:05:29PM -0700, Kees Cook wrote:
>> On Mon, Oct 30, 2017 at 3:08 AM, Daniel Vetter <daniel@...ll.ch> wrote:
>> > On Tue, Oct 24, 2017 at 08:16:09AM -0700, Kees Cook wrote:
>> >> In preparation for unconditionally passing the struct timer_list pointer to
>> >> all timer callbacks, switch to using the new timer_setup() and from_timer()
>> >> to pass the timer pointer explicitly.
>> >>
>> >> Cc: Patrik Jakobsson <patrik.r.jakobsson@...il.com>
>> >> Cc: David Airlie <airlied@...ux.ie>
>> >> Cc: dri-devel@...ts.freedesktop.org
>> >> Signed-off-by: Kees Cook <keescook@...omium.org>
>> >
>> > Do you expect drm folks to apply this, or is this part of a larger refactoring?
>>
>> If the drm tree includes -rc3, you can carry these. If you don't want
>> to carry these and want the timer tree to carry them, we can do that
>> too.
>
> Applied to drm-misc-next for 4.16 (we're way past freeze for 4.15
> already).

Since this is one of the few remaining "non-trivial" users of the
ancient init_timer() API, would you mind if the timers tree carried
this for 4.15? I'm trying to entirely remove the init_timer() API (and
if I can, remove the old setup_*timer() API too).

Thanks!

-Kees

-- 
Kees Cook
Pixel Security