linux-kernel - Re: [PATCH v11 08/15] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171031152406.GA55546@localhost.localdomain>
Date:   Tue, 31 Oct 2017 08:24:06 -0700
From:   Darren Hart <dvhart@...radead.org>
To:     Mario.Limonciello@...l.com
Cc:     pali.rohar@...il.com, andy.shevchenko@...il.com,
        linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        luto@...nel.org, quasisec@...gle.com, rjw@...ysocki.net,
        mjg59@...gle.com, hch@....de, greg@...ah.com,
        gnomes@...rguk.ukuu.org.uk
Subject: Re: [PATCH v11 08/15] platform/x86: dell-smbios: Add a sysfs
 interface for SMBIOS tokens

On Mon, Oct 30, 2017 at 01:36:16PM +0000, Mario.Limonciello@...l.com wrote:
> > 
> > Hint: you can move this check out of j-loop as condition is independent
> > of it.
> 
> That's true, thanks.
> 
> > 
> > Also how many tokens are there? Is not quadratic solution too slow?
> > 
> 
> ~< 250 on most machines is what I've seen.  To me that that's a small
> enough number that this is quick.  It only happens at initialization.

Agreed, not a hot path. Prefer simplicity to performance here.

-- 
Darren Hart
VMware Open Source Technology Center