linux-kernel - Re: [PATCH] [media] mxl111sf: remove redundant assignment to index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOcJUbypnurqiwO0wZvaDVNLRij+_hsEiJ4eKG7G0b1-LqmEMw@mail.gmail.com>
Date:   Tue, 31 Oct 2017 11:39:56 -0400
From:   Michael Ira Krufky <mkrufky@...uxtv.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media <linux-media@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [media] mxl111sf: remove redundant assignment to index

On Sun, Oct 29, 2017 at 8:50 AM, Colin King <colin.king@...onical.com> wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> Variable index is set to zero and then set to zero again
> a few lines later in a for loop initialization. Remove the
> redundant setting of index to zero. Cleans up the clang
> warning:
>
> drivers/media/usb/dvb-usb-v2/mxl111sf-i2c.c:519:3: warning: Value
> stored to 'index' is never read
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Michael Ira Krufky <mkrufky@...uxtv.org>


Thanks for the patch!


> ---
>  drivers/media/usb/dvb-usb-v2/mxl111sf-i2c.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/usb/dvb-usb-v2/mxl111sf-i2c.c b/drivers/media/usb/dvb-usb-v2/mxl111sf-i2c.c
> index 0eb33e043079..a221bb8a12b4 100644
> --- a/drivers/media/usb/dvb-usb-v2/mxl111sf-i2c.c
> +++ b/drivers/media/usb/dvb-usb-v2/mxl111sf-i2c.c
> @@ -516,7 +516,6 @@ static int mxl111sf_i2c_hw_xfer_msg(struct mxl111sf_state *state,
>                    data required to program */
>                 block_len = (msg->len / 8);
>                 left_over_len = (msg->len % 8);
> -               index = 0;
>
>                 mxl_i2c("block_len %d, left_over_len %d",
>                         block_len, left_over_len);
> --
> 2.14.1
>