linux-kernel - Re: [RFC PATCH 1/2] scripts: warn about invalid MAINTAINER patterns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1509464878.31043.2.camel@perches.com>
Date:   Tue, 31 Oct 2017 08:47:58 -0700
From:   Joe Perches <joe@...ches.com>
To:     Tom Saeger <tom.saeger@...cle.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 1/2] scripts: warn about invalid MAINTAINER patterns

On Tue, 2017-10-31 at 09:46 -0500, Tom Saeger wrote:
> Add get_maintainer.pl option to warn about invalid
> "F" and "X" patterns found in MAINTAINERS file(s).

Hi Tom.

I've had a similar script for many years.

This implementation is very inefficient as it runs
git ls-files once for each file pattern.

It's much more efficient to do a global git ls-files
once and store the result and then do a local grep
for pattern matches.

cheers, Joe