linux-kernel - Re: [PATCH] xfs: remove redundant assignment to variable bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171031165552.GD4911@magnolia>
Date:   Tue, 31 Oct 2017 09:55:52 -0700
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     Colin King <colin.king@...onical.com>
Cc:     linux-xfs@...r.kernel.org, Brian Foster <bfoster@...hat.com>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xfs: remove redundant assignment to variable bit

On Tue, Oct 31, 2017 at 11:13:50AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Variable bit is being assigned a value that is never read, hence
> the assignment is redundant and can be removed. Cleans up clang
> warning:
> 
> fs/xfs/libxfs/xfs_rtbitmap.c:675:3: warning: Value stored to
> 'bit' is never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com>

> ---
>  fs/xfs/libxfs/xfs_rtbitmap.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_rtbitmap.c b/fs/xfs/libxfs/xfs_rtbitmap.c
> index 5d4e43ef4eea..ac09c4333485 100644
> --- a/fs/xfs/libxfs/xfs_rtbitmap.c
> +++ b/fs/xfs/libxfs/xfs_rtbitmap.c
> @@ -672,7 +672,6 @@ xfs_rtmodify_range(
>  		/*
>  		 * Compute a mask of relevant bits.
>  		 */
> -		bit = 0;
>  		mask = ((xfs_rtword_t)1 << lastbit) - 1;
>  		/*
>  		 * Set/clear the active bits.
> -- 
> 2.14.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html