linux-kernel - Re: [PATCH] scsi: qla2xxx: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AF4B68F-9343-437E-ADA7-1675E32998B9@cavium.com>
Date:   Tue, 31 Oct 2017 18:36:07 +0000
From:   "Madhani, Himanshu" <Himanshu.Madhani@...ium.com>
To:     Kees Cook <keescook@...omium.org>
CC:     Bart Van Assche <bart.vanassche@....com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "jejb@...ux.vnet.ibm.com" <jejb@...ux.vnet.ibm.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        Dept-Eng QLA2xxx Upstream <qla2xxx-upstream@...ium.com>
Subject: Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

Hi Kees, 

> On Oct 31, 2017, at 11:28 AM, Kees Cook <keescook@...omium.org> wrote:
> 
> How very strange. I don't see any code change with this patch. Even
> the passed arguments are the same; it's only enforcing the types now.
> And the system is fine with only this patch reverted?

Yes. Agree patch looks okay, but with the patch built into driver I see
system going into infinite loop of trying to bring link up and lock up 
after few minutes, Only way to recover is hard reboot. 

I reverted this patch after system boot up and rebuild qla2xxx and able
to load driver.

Thanks,
- Himanshu