linux-kernel - Re: [RFC/RFT PATCH 0/6] Switch GHES ioremap_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6373c223-5b53-f6a0-6867-a2be8bb9f44c@codeaurora.org>
Date:   Tue, 31 Oct 2017 14:46:36 -0400
From:   Tyler Baicar <tbaicar@...eaurora.org>
To:     James Morse <james.morse@....com>, linux-acpi@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        x86@...nel.org, Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>, Borislav Petkov <bp@...e.de>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>, Tony Luck <tony.luck@...el.com>,
        Dongjiu Geng <gengdongjiu@...wei.com>,
        Xie XiuQi <xiexiuqi@...wei.com>, torvalds@...ux-foundation.org
Subject: Re: [RFC/RFT PATCH 0/6] Switch GHES ioremap_page_range() to use
 fixmap

On 10/31/2017 11:38 AM, James Morse wrote:
> GHES is doing ioremap_page_range() in both NMI and irq context, neither
> are safe as it may sleep to allocate intermediate levels of page table.
>
> Replace the NMI/irq GHES_IOREMAP_PAGES to use a fixmap entry each.
>
> After this nothing uses ghes_ioremap_area or arch_apei_flush_tlb_one(),
> rip them out.
>
> RFC as I've only build-tested this on x86. For arm64 I've tested it on a
> software model. Any more testing would be welcome. These patches are based
> on rc7.
For the arm64 and APEI patches:
Tested-by: Tyler Baicar <tbaicar@...eaurora.org>

Verified on arm64. I no longer see the BUGs in the GHES code. Thanks!

Tyler

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.