linux-kernel - Re: [PATCH] selftests/ftrace: Do not use arch dependent do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171031153730.23a18072@gandalf.local.home>
Date:   Tue, 31 Oct 2017 15:37:30 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>, shuah@...nel.org
Cc:     linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        sumit.semwal@...aro.org, naresh.kamboju@...aro.org
Subject: Re: [PATCH] selftests/ftrace: Do not use arch dependent do_IRQ as a
 target function

On Fri, 27 Oct 2017 15:10:30 +0900
Masami Hiramatsu <mhiramat@...nel.org> wrote:

> Instead using arch-dependent do_IRQ, use do_softirq as a
> target function.
> 
> Applying do_IRQ to set_ftrace_filter always fail on arm/arm64 and any
> other architectures which don't define do_IRQ. So, instead of using
> that, use do_softirq which is defined in kernel/softirq.c.
> 
> Signed-off-by: Masami Hiramatsu <mhiramat@...nel.org>

Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

Shuah,

Can you take this in your tree?

Thanks!

-- Steve

> ---
>  .../ftrace/test.d/ftrace/func_set_ftrace_file.tc   |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> index 113b4d9bc733..20f15c858af6 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> @@ -32,7 +32,7 @@ do_reset
>  
>  FILTER=set_ftrace_filter
>  FUNC1="schedule"
> -FUNC2="do_IRQ"
> +FUNC2="do_softirq"
>  
>  ALL_FUNCS="#### all functions enabled ####"
>