linux-kernel - Re: [PATCH v2] x86/cpufeatures: Enable new SSE/AVX/AVX512 cpu features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171031200241.jixw35zatcrk6yyh@pd.tnic>
Date:   Tue, 31 Oct 2017 21:02:41 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     "Yu, Fenghua" <fenghua.yu@...el.com>
Cc:     "Kammela, Gayatri" <gayatri.kammela@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "hpa@...ux.intel.com" <hpa@...ux.intel.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "Kleen, Andi" <andi.kleen@...el.com>,
        "Shankar, Ravi V" <ravi.v.shankar@...el.com>,
        "Neri, Ricardo" <ricardo.neri@...el.com>,
        "Zhong, Yang" <yang.zhong@...el.com>
Subject: Re: [PATCH v2]  x86/cpufeatures: Enable new SSE/AVX/AVX512 cpu
 features

On Tue, Oct 31, 2017 at 07:37:29PM +0000, Yu, Fenghua wrote:
> Should we change the legacy names as well? User apps may use the names
> already. Changing the names may break the apps.

Yeah, we can't do that.

> If we do make all uniform, do you prefer adding "_" after AVX512?

Well, I think we can forget the whole endeavor. We already have the two
variants, which we can't change anymore:

#define X86_FEATURE_AVX512_4VNNIW (7*32+16) /* AVX-512 Neural Network Instructions */
#define X86_FEATURE_AVX512_4FMAPS (7*32+17) /* AVX-512 Multiply Accumulation Single precision */
#define X86_FEATURE_AVX512F     ( 9*32+16) /* AVX-512 Foundation */
#define X86_FEATURE_AVX512DQ    ( 9*32+17) /* AVX-512 DQ (Double/Quad granular) Instructions */
#define X86_FEATURE_AVX512IFMA  ( 9*32+21) /* AVX-512 Integer Fused Multiply-Add instructions */
#define X86_FEATURE_AVX512PF    ( 9*32+26) /* AVX-512 Prefetch */
#define X86_FEATURE_AVX512ER    ( 9*32+27) /* AVX-512 Exponential and Reciprocal */
#define X86_FEATURE_AVX512CD    ( 9*32+28) /* AVX-512 Conflict Detection */
#define X86_FEATURE_AVX512BW    ( 9*32+30) /* AVX-512 BW (Byte/Word granular) Instructions */
#define X86_FEATURE_AVX512VL    ( 9*32+31) /* AVX-512 VL (128/256 Vector Length) Extensions */
#define X86_FEATURE_AVX512VBMI  (16*32+ 1) /* AVX512 Vector Bit Manipulation instructions*/
#define X86_FEATURE_AVX512_VPOPCNTDQ (16*32+14) /* POPCNT for vectors of DW/QW */

:-\

Oh well, as long as the AVX512 prefix is there at least the grepping works.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.