lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 1 Nov 2017 16:08:44 -0700 From: Laura Abbott <labbott@...hat.com> To: Colin King <colin.king@...onical.com>, Sumit Semwal <sumit.semwal@...aro.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Arve Hjønnevåg <arve@...roid.com>, Riley Andrews <riandrews@...roid.com>, devel@...verdev.osuosl.org Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: android: ion: remove redundant variable table On 10/31/2017 07:02 AM, Colin King wrote: > From: Colin Ian King <colin.king@...onical.com> > > Variable table is being set but is never read, it is therefore > redundant and can be removed. Cleans up clang warning: > > drivers/staging/android/ion/ion.c:112:2: warning: Value stored to 'table' is never read > Acked-by: Laura Abbott <labbott@...hat.com> > Signed-off-by: Colin Ian King <colin.king@...onical.com> > --- > drivers/staging/android/ion/ion.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c > index 93e2c90fa77d..a7d9b0e98572 100644 > --- a/drivers/staging/android/ion/ion.c > +++ b/drivers/staging/android/ion/ion.c > @@ -81,7 +81,6 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap, > unsigned long flags) > { > struct ion_buffer *buffer; > - struct sg_table *table; > int ret; > > buffer = kzalloc(sizeof(*buffer), GFP_KERNEL); > @@ -109,7 +108,6 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap, > goto err1; > } > > - table = buffer->sg_table; > buffer->dev = dev; > buffer->size = len; > >
Powered by blists - more mailing lists