linux-kernel - Re: Excessive logging in thunderbolt driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171101074154.GT2283@lahna.fi.intel.com>
Date:   Wed, 1 Nov 2017 09:41:54 +0200
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     andreas.noever@...il.com, michael.jamet@...el.com,
        yehezkel.bernat@...el.com, linux-kernel@...r.kernel.org
Subject: Re: Excessive logging in thunderbolt driver

On Tue, Oct 31, 2017 at 10:45:46PM +0100, Stephen Hemminger wrote:
> The thunderbolt driver needs to stop logging.
> All these debug messages and the laptop is on battery with no devices connected.
> (I did use a USB key, but that is not a thunderbolt device).
> 
> IMHO a production driver should log nothing in normal operation.
> If you insist, the one message when device is found on discovery/probe
> is allowed at INFO level.
> 
> All the rest should just go away, or be turned into pr_debug().

I agree and it is on my todo list for this driver.