linux-kernel - Re: [PATCH 0/7] perf tools: Small sample parsing speedup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171101083955.GA25146@danjae.aot.lge.com>
Date:   Wed, 1 Nov 2017 17:39:55 +0900
From:   Namhyung Kim <namhyung@...nel.org>
To:     Jiri Olsa <jolsa@...nel.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        David Ahern <dsahern@...il.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>, kernel-team@....com
Subject: Re: [PATCH 0/7] perf tools: Small sample parsing speedup

Hi Jiri,

On Tue, Oct 31, 2017 at 10:29:40AM +0100, Jiri Olsa wrote:
> hi,
> sending small speedup fix for sample parsing code
> and few assorted fixes.

Nice work, for patch 1-5:

  Acked-by: Namhyung Kim <namhyung@...nel.org>

But I'm not sure for patch 6 and 7 as tool and event arguments are
passed to others consistently.

Thanks,
Namhyung


> 
> Also available in:
>   https://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
>   perf/fixes
> 
> thanks,
> jirka
> 
> 
> ---
> Jiri Olsa (7):
>       perf tools: Reset cursor arg instead of callchain_cursor
>       perf tools: Centralize perf_sample initialization
>       perf tools: Add perf_evlist__parse_sample_timestamp function
>       perf tools: Pass timestamp arg in perf_session__queue_event
>       perf tools: Optimize sample parsing for ordered events
>       perf tools: Remove perf_tool from event_op2
>       perf tools: Remove perf_tool from event_op3
> 
>  tools/perf/builtin-inject.c      |  32 ++++++++++++++------------------
>  tools/perf/builtin-kvm.c         |   8 ++++----
>  tools/perf/builtin-script.c      |  22 ++++++++++------------
>  tools/perf/builtin-stat.c        |  23 +++++++++++------------
>  tools/perf/util/auxtrace.c       |  17 +++++++----------
>  tools/perf/util/auxtrace.h       |  15 ++++++---------
>  tools/perf/util/evlist.c         |  11 +++++++++++
>  tools/perf/util/evlist.h         |   4 ++++
>  tools/perf/util/evsel.c          |  71 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------
>  tools/perf/util/evsel.h          |   4 ++++
>  tools/perf/util/header.c         |  16 +++++++---------
>  tools/perf/util/header.h         |  15 ++++++---------
>  tools/perf/util/machine.c        |   2 +-
>  tools/perf/util/ordered-events.c |   3 +--
>  tools/perf/util/ordered-events.h |   2 +-
>  tools/perf/util/session.c        | 120 +++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------------------------------------
>  tools/perf/util/session.h        |   7 +++----
>  tools/perf/util/stat.c           |   5 ++---
>  tools/perf/util/stat.h           |   5 ++---
>  tools/perf/util/tool.h           |   7 ++-----
>  20 files changed, 208 insertions(+), 181 deletions(-)