lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 1 Nov 2017 01:45:55 -0700 From: tip-bot for Matthias Kaehlcke <tipbot@...or.com> To: linux-tip-commits@...r.kernel.org Cc: groeck@...omium.org, mka@...omium.org, linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org, mingo@...nel.org, nick.desaulniers@...il.com, tglx@...utronix.de, dianders@...omium.org, shile.zhang@...ia.com, peterz@...radead.org, hpa@...or.com Subject: [tip:sched/core] sched/sysctl: Fix attributes of some extern declarations Commit-ID: a9903f04e0a4ea522d959c2f287cdf0ab029e324 Gitweb: https://git.kernel.org/tip/a9903f04e0a4ea522d959c2f287cdf0ab029e324 Author: Matthias Kaehlcke <mka@...omium.org> AuthorDate: Mon, 30 Oct 2017 11:08:16 -0700 Committer: Ingo Molnar <mingo@...nel.org> CommitDate: Wed, 1 Nov 2017 09:36:17 +0100 sched/sysctl: Fix attributes of some extern declarations The definition of sysctl_sched_migration_cost, sysctl_sched_nr_migrate and sysctl_sched_time_avg includes the attribute const_debug. This attribute is not part of the extern declaration of these variables in include/linux/sched/sysctl.h, while it is in kernel/sched/sched.h, and as a result Clang generates warnings like this: kernel/sched/sched.h:1618:33: warning: section attribute is specified on redeclared variable [-Wsection] extern const_debug unsigned int sysctl_sched_time_avg; ^ ./include/linux/sched/sysctl.h:42:21: note: previous declaration is here extern unsigned int sysctl_sched_time_avg; The header only declares the variables when CONFIG_SCHED_DEBUG is defined, therefore it is not necessary to duplicate the definition of const_debug. Instead we can use the attribute __read_mostly, which is the expansion of const_debug when CONFIG_SCHED_DEBUG=y is set. Signed-off-by: Matthias Kaehlcke <mka@...omium.org> Reviewed-by: Nick Desaulniers <nick.desaulniers@...il.com> Cc: Douglas Anderson <dianders@...omium.org> Cc: Guenter Roeck <groeck@...omium.org> Cc: Linus Torvalds <torvalds@...ux-foundation.org> Cc: Peter Zijlstra <peterz@...radead.org> Cc: Shile Zhang <shile.zhang@...ia.com> Cc: Thomas Gleixner <tglx@...utronix.de> Link: http://lkml.kernel.org/r/20171030180816.170850-1-mka@chromium.org Signed-off-by: Ingo Molnar <mingo@...nel.org> --- include/linux/sched/sysctl.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/sched/sysctl.h b/include/linux/sched/sysctl.h index 0f5ecd4..d34c823 100644 --- a/include/linux/sched/sysctl.h +++ b/include/linux/sched/sysctl.h @@ -37,9 +37,9 @@ extern unsigned int sysctl_numa_balancing_scan_period_max; extern unsigned int sysctl_numa_balancing_scan_size; #ifdef CONFIG_SCHED_DEBUG -extern unsigned int sysctl_sched_migration_cost; -extern unsigned int sysctl_sched_nr_migrate; -extern unsigned int sysctl_sched_time_avg; +extern __read_mostly unsigned int sysctl_sched_migration_cost; +extern __read_mostly unsigned int sysctl_sched_nr_migrate; +extern __read_mostly unsigned int sysctl_sched_time_avg; int sched_proc_update_handler(struct ctl_table *table, int write, void __user *buffer, size_t *length,
Powered by blists - more mailing lists