linux-kernel - Re: [PATCH] pinctrl: sirf: Use common error handling code in sirfsoc_dt_node_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171101103335.y5t7id3okn55r6a2@mwanda>
Date:   Wed, 1 Nov 2017 13:33:35 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Barry Song <baohua@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Julia Lawall <Julia.Lawall@...6.fr>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Patrice Chotard <patrice.chotard@...com>,
        Rob Herring <robh@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: sirf: Use common error handling code in
 sirfsoc_dt_node_to_map()

Really, the of_node_put() is connected to the loop and not the function
so the original code is the right way to do it.  Otherwise if we added
more error handling to the function then normal kernel error handling
wouldn't work naturally.

regards,
dan carpenter