linux-kernel - Re: [PATCH] wan: wanxl: remove redundant assignment to stat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59F9A6ED.7060301@bfs.de>
Date:   Wed, 01 Nov 2017 11:50:21 +0100
From:   walter harms <wharms@....de>
To:     Colin King <colin.king@...onical.com>
CC:     Krzysztof Halasa <khc@...waw.pl>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] wan: wanxl: remove redundant assignment to stat



Am 01.11.2017 09:49, schrieb Colin King:
> From: Colin Ian King <colin.king@...onical.com>
> 
> stat set to zero and the value is never read, instead stat is
> set again in the do-loop. Hence the setting to zero is redundant
> and can be removed. Cleans up clang warning:
> 
> drivers/net/wan/wanxl.c:737:2: warning: Value stored to 'stat'
> is never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/net/wan/wanxl.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/wan/wanxl.c b/drivers/net/wan/wanxl.c
> index 0c7317520ed3..d573a57bc301 100644
> --- a/drivers/net/wan/wanxl.c
> +++ b/drivers/net/wan/wanxl.c
> @@ -734,7 +734,6 @@ static int wanxl_pci_init_one(struct pci_dev *pdev,
>  		return -ENODEV;
>  	}
>  
> -	stat = 0;
>  	timeout = jiffies + 5 * HZ;
>  	do {
>  		if ((stat = readl(card->plx + PLX_MAILBOX_5)) != 0)

it is std. practice to have the pattern:
 a=b;
 if (a == c) ...
maybe that can be done also here.
 stat = readl(card->plx + PLX_MAILBOX_5);
 if ( stat != 0)

just a hint.

 re,
  wh