lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 1 Nov 2017 13:31:02 +0100 From: Andrew Lunn <andrew@...n.ch> To: "Maciej S. Szmigiero" <mail@...iej.szmigiero.name> Cc: Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org, linux-kernel <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2] net: phy: leds: Add support for "link" trigger > Yes, I did it the same way as the existing code did for phy->phy_led_triggers > for reasons of both consistency and also to be on the safe side because > maybe there is some non-obvious reason why it has to be freed > explicitly (?). Hi Maciej Occasionally, there is a need to call devm_kfree(). But i don't see anything here why it is needed. So i would drop your devm_kfree(), and if you feel like it, add an additional patch removing the existing one. Thanks Andrew
Powered by blists - more mailing lists