lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 1 Nov 2017 11:41:05 -0300 From: Arnaldo Carvalho de Melo <acme@...nel.org> To: Namhyung Kim <namhyung@...nel.org> Cc: Milian Wolff <milian.wolff@...b.com>, Ingo Molnar <mingo@...nel.org>, Peter Zijlstra <a.p.zijlstra@...llo.nl>, Jiri Olsa <jolsa@...nel.org>, LKML <linux-kernel@...r.kernel.org>, kernel-team@....com, Jin Yao <yao.jin@...ux.intel.com> Subject: Re: [PATCH 2/2] perf tools: Show correct function name for srcline of callchains Em Wed, Nov 01, 2017 at 09:05:59PM +0900, Namhyung Kim escreveu: > Hi Milian, > > On Wed, Nov 01, 2017 at 10:57:12AM +0100, Milian Wolff wrote: > > On Tuesday, October 31, 2017 3:06:54 AM CET Namhyung Kim wrote: > > > When libbfd is not used, it doesn't show proper function name and reuse > > > the original symbol of the sample. That's because it passes the > > > original sym to inline_list__append(). As `addr2line -f` returns > > > function names as well, use that to create ad inline_sym and pass it to > > > inline_list__append(). > > > > Typo above: "ad" -> "and" > > I think it's "an" instead of "and". :) I didn't catch that, bummer! 8-) Ok, made the ad -> and -> an change :-) And added Milian's Reviewed-by, - Arnaldo > > Otherwise these patches look fine to me > > > > Reviewed-by: Milian Wolff <milian.wolff@...b.com> > > Thanks, > Namhyung
Powered by blists - more mailing lists