lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 01 Nov 2017 14:58:54 +0000 From: James Morse <james.morse@....com> To: Linus Torvalds <torvalds@...ux-foundation.org> CC: Linux ACPI <linux-acpi@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, the arch/x86 maintainers <x86@...nel.org>, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will.deacon@....com>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, "H . Peter Anvin" <hpa@...or.com>, Borislav Petkov <bp@...e.de>, "Rafael J . Wysocki" <rjw@...ysocki.net>, Len Brown <lenb@...nel.org>, Tony Luck <tony.luck@...el.com>, Tyler Baicar <tbaicar@...eaurora.org>, Dongjiu Geng <gengdongjiu@...wei.com>, Xie XiuQi <xiexiuqi@...wei.com> Subject: Re: [RFC/RFT PATCH 0/6] Switch GHES ioremap_page_range() to use fixmap Hi Linus, On 31/10/17 15:52, Linus Torvalds wrote: > On Tue, Oct 31, 2017 at 8:38 AM, James Morse <james.morse@....com> wrote: >> 7 files changed, 30 insertions(+), 85 deletions(-) > > Lovely. > > I obviously can't test it, but it looks fine. I *would* suggest just > making the "add fixmap entries" commits with the code that actually > uses them. There's no real reason to have two commits that just add > two entries that aren't used yet. > > If it was some meaningful helper function where a split of the commits > makes each commit easier to read, that would be one thing. As it is, > the split just makes it harder to look at the history of the code (ie > "I wonder where this was introduced - let's use 'git blame'. Oh, > that's not useful"). I will squash the first three patches together to fix this, and add something about HAVE_ACPI_APEI to the commit message. (I'm still holding out for someone to test this on an x86 system with NOTIFY_NMI) Thanks, James
Powered by blists - more mailing lists