linux-kernel - Re: [PATCH] f2fs: don't bother with inode->i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1836bd00-d64e-feb5-4033-8ffd5934f47f@huawei.com>
Date:   Wed, 1 Nov 2017 10:14:11 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Jeff Layton <jlayton@...nel.org>, <jaegeuk@...nel.org>
CC:     <linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-f2fs-devel@...ts.sourceforge.net>
Subject: Re: [PATCH] f2fs: don't bother with inode->i_version

On 2017/10/30 23:11, Jeff Layton wrote:
> From: Jeff Layton <jlayton@...hat.com>
> 
> f2fs does not set the SB_I_VERSION flag, so the i_version will never
> be incremented on write. It was recently changed to increment the
> i_version on a quota write, which isn't necessary here.
> 
> Signed-off-by: Jeff Layton <jlayton@...hat.com>

Reviewed-by: Chao Yu <yuchao0@...wei.com>

Thanks,

> ---
>  fs/f2fs/super.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 933c3d529e65..b3359158e7be 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -618,7 +618,6 @@ static struct inode *f2fs_alloc_inode(struct super_block *sb)
>  	init_once((void *) fi);
>  
>  	/* Initialize f2fs-specific inode info */
> -	fi->vfs_inode.i_version = 1;
>  	atomic_set(&fi->dirty_pages, 0);
>  	fi->i_current_depth = 1;
>  	fi->i_advise = 0;
> @@ -1386,7 +1385,6 @@ static ssize_t f2fs_quota_write(struct super_block *sb, int type,
>  
>  	if (len == towrite)
>  		return 0;
> -	inode->i_version++;
>  	inode->i_mtime = inode->i_ctime = current_time(inode);
>  	f2fs_mark_inode_dirty_sync(inode, false);
>  	return len - towrite;
>