linux-kernel - Re: [PATCH 4.4 11/41] KEYS: fix writing past end of user-supplied buffer in keyring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <11969.1509549857@warthog.procyon.org.uk>
Date:   Wed, 01 Nov 2017 15:24:17 +0000
From:   David Howells <dhowells@...hat.com>
To:     Ben Hutchings <ben.hutchings@...ethink.co.uk>
Cc:     dhowells@...hat.com, Eric Biggers <ebiggers@...gle.com>,
        stable@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4.4 11/41] KEYS: fix writing past end of user-supplied buffer in keyring_read()

Ben Hutchings <ben.hutchings@...ethink.co.uk> wrote:

> > So do we really make it keep filling the buffer, even though that contradicts
> > the man page?
> 
> I don't think any application is likely to care about this.  The
> documentation should also be changed to say that if the buffer is too
> small, "data may or may not be copied to the buffer" or "the contents
> of the buffer are undefined".

Okay, let's go with that.

David