linux-kernel - Re: [PATCH v3] kprobes, x86/alternatives: use text_mutex to protect smp_alt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171101122455.498b1a5a@gandalf.local.home>
Date:   Wed, 1 Nov 2017 12:24:55 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Zhou Chengming <zhouchengming1@...wei.com>
Cc:     <mingo@...nel.org>, <mhiramat@...nel.org>, <peterz@...radead.org>,
        <bp@...e.de>, <hpa@...or.com>, <davem@...emloft.net>,
        <jkosina@...e.cz>, <x86@...nel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] kprobes, x86/alternatives: use text_mutex to protect
 smp_alt_modules

On Wed, 1 Nov 2017 19:00:34 +0800
Zhou Chengming <zhouchengming1@...wei.com> wrote:

> diff --git a/kernel/extable.c b/kernel/extable.c
> index 9aa1cc4..ec64cf5 100644
> --- a/kernel/extable.c
> +++ b/kernel/extable.c
> @@ -31,6 +31,8 @@
>   * mutex protecting text section modification (dynamic code patching).
>   * some users need to sleep (allocating memory...) while they hold this lock.
>   *
> + * Note: also protect smp alternatives modification on x86.

"Note: Also protects smp alternatives modification on x86"

Slight grammar fix, but other than that.

Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve

> + *
>   * NOT exported to modules - patching kernel text is a really delicate matter.
>   */
>  DEFINE_MUTEX(text_mutex);