linux-kernel - Re: [RFC PATCH 2/7] typec: tcpm: Add ADO header for Alert message handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171101172007.GA14585@kroah.com>
Date:   Wed, 1 Nov 2017 18:20:07 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Adam Thomson <Adam.Thomson.Opensource@...semi.com>
Cc:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Sebastian Reichel <sre@...nel.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Yueyao Zhu <yueyao.zhu@...il.com>,
        Rui Miguel Silva <rmfrfs@...il.com>,
        linux-usb@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, support.opensource@...semi.com
Subject: Re: [RFC PATCH 2/7] typec: tcpm: Add ADO header for Alert message
 handling

On Wed, Nov 01, 2017 at 05:03:10PM +0000, Adam Thomson wrote:
> This commit adds a header providing definitions for handling Alert
> messages. Currently the header only focuses on handling incoming
> alerts.
> 
> Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@...semi.com>
> ---
>  include/linux/usb/pd_ado.h | 49 ++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 49 insertions(+)
>  create mode 100644 include/linux/usb/pd_ado.h
> 
> diff --git a/include/linux/usb/pd_ado.h b/include/linux/usb/pd_ado.h
> new file mode 100644
> index 0000000..edcbcfa
> --- /dev/null
> +++ b/include/linux/usb/pd_ado.h
> @@ -0,0 +1,49 @@
> +/*
> + * Copyright (c) 2017 Dialog Semiconductor
> + *
> + * Author: Adam Thomson <Adam.Thomson.Opensource@...semi.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.

I have to ask, do you _really_ mean "any later version"?



> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#ifndef __LINUX_USB_PD_ADO_H
> +#define __LINUX_USB_PD_ADO_H
> +
> +/* ADO : Alert Data Object */
> +#define ADO_TYPE_SHIFT			24
> +#define ADO_TYPE_MASK			0xff
> +#define ADO_FIXED_BATT_SHIFT		20
> +#define ADO_FIXED_BATT_MASK		0xf
> +#define ADO_HOT_SWAP_BATT_SHIFT		16
> +#define ADO_HOT_SWAP_BATT_MASK		0xf

USB_ prefixes perhaps?

> +
> +#define ADO_TYPE_BATT_STATUS_CHANGE	BIT(1)
> +#define ADO_TYPE_OCP			BIT(2)
> +#define ADO_TYPE_OTP			BIT(3)
> +#define ADO_TYPE_OP_COND_CHANGE		BIT(4)
> +#define ADO_TYPE_SRC_INPUT_CHANGE	BIT(5)
> +#define ADO_TYPE_OVP			BIT(6)
> +
> +static inline unsigned int ado_type(u32 ado)
> +{
> +	return (ado >> ADO_TYPE_SHIFT) & ADO_TYPE_MASK;
> +}

usb_ prefix for this and the other inline functions as well?

thanks,

greg k-h