lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 1 Nov 2017 18:26:25 +0100 (CET) From: Thomas Gleixner <tglx@...utronix.de> To: Borislav Petkov <bp@...e.de> cc: Andy Lutomirski <luto@...nel.org>, X86 ML <x86@...nel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Brian Gerst <brgerst@...il.com>, Dave Hansen <dave.hansen@...el.com>, Linus Torvalds <torvalds@...ux-foundation.org> Subject: Re: [PATCH 07/18] x86/asm/64: Merge the fast and slow SYSRET paths On Wed, 1 Nov 2017, Borislav Petkov wrote: > On Wed, Nov 01, 2017 at 04:29:21AM -0700, Andy Lutomirski wrote: > > I'm inclined to leave it. I first wrote it without the long name and > > then I had to re-read the code to make sure I got the register state > > right. The long name serves as documentation that we need rcx and r11 > > to have special contents. There's only one place that jumps there and > > it's in the same function. > > Frankly, I'd prefer a sane label name and a good comment over it instead > of insanely long label name which is not as explanatory as a normal > english sentence or two. Comments are always appreciated, but in that code really expressive labels make it way better to follow and prevent accidental wreckage. Thanks, tglx
Powered by blists - more mailing lists