linux-kernel - Re: [PATCH v2] fs: guard_bio_eod() needs to consider partitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171101174942.GJ21917@psuche>
Date:   Wed, 1 Nov 2017 11:49:42 -0600
From:   Greg Edwards <gedwards@....com>
To:     <linux-fsdevel@...r.kernel.org>
CC:     Christoph Hellwig <hch@....de>, Al Viro <viro@...iv.linux.org.uk>,
        "Jens Axboe" <axboe@...nel.dk>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] fs: guard_bio_eod() needs to consider partitions

On Tue, Oct 24, 2017 at 11:21:48AM -0600, Greg Edwards wrote:
> guard_bio_eod() needs to look at the partition capacity, not just the
> capacity of the whole device, when determining if truncation is
> necessary.
>
> [   60.268688] attempt to access beyond end of device
> [   60.268690] unknown-block(9,1): rw=0, want=67103509, limit=67103506
> [   60.268693] buffer_io_error: 2 callbacks suppressed
> [   60.268696] Buffer I/O error on dev md1p7, logical block 4524305, async page read
>
> Fixes: 74d46992e0d9 ("block: replace bi_bdev with a gendisk pointer and partitions index")
> Signed-off-by: Greg Edwards <gedwards@....com>
> ---
> Changes from v1:
>   * use __disk_get_part instead of disk_get_part, similar to what
>     blk_partition_remap does

Al, Christoph,

Any thoughts on this version?

It would be nice to get this fixed before 4.14 goes out, as this is a
regression from previous releases.

Greg