linux-kernel - Re: [PATCH 0/4] scsi: qla2xxx: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jJnB9rAN_qjrdh3iGfWtB2-p5dqNOtqScnSZn9j20iFgg@mail.gmail.com>
Date:   Wed, 1 Nov 2017 11:46:41 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Himanshu Madhani <Himanshu.Madhani@...ium.com>
Cc:     Kees Cook <keescook@...omium.org>,
        Bart Van Assche <bart.vanassche@....com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        qla2xxx-upstream@...gic.com, linux-scsi@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 0/4] scsi: qla2xxx: Convert timers to use timer_setup()

On Tue, Oct 31, 2017 at 12:13 PM, Kees Cook <keescook@...omium.org> wrote:
> This breaks out the logical steps to convert the qla2xxx timers:
>
> 1) init_timer() -> setup_timer()
> 2) refactor qla2x00_start_timer() to not pass callback as argument
> 3) qla2x00_timer() to use timer_setup()
> 4) qla2x00_sp_timeout() to use timer_setup()
>
> The resulting diff is identical to the patch that appears to lock up
> the driver. This should help identify which step causes this behavior.

Hi, just curious if there's been any progress on debugging the issue
you saw with this series?

Thanks!

-Kees

-- 
Kees Cook
Pixel Security