linux-kernel - Re: [PATCH] selftests/ftrace: Do not use arch dependent do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7b45330e-1817-87d6-4469-c530e19b784d@kernel.org>
Date:   Wed, 1 Nov 2017 15:15:40 -0600
From:   Shuah Khan <shuah@...nel.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>,
        linux-kselftest@...r.kernel.org,
        Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-kernel@...r.kernel.org, sumit.semwal@...aro.org,
        naresh.kamboju@...aro.org, Shuah Khan <shuahkh@....samsung.com>,
        Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH] selftests/ftrace: Do not use arch dependent do_IRQ as a
 target function

On 10/27/2017 12:10 AM, Masami Hiramatsu wrote:
> Instead using arch-dependent do_IRQ, use do_softirq as a
> target function.
> 
> Applying do_IRQ to set_ftrace_filter always fail on arm/arm64 and any
> other architectures which don't define do_IRQ. So, instead of using
> that, use do_softirq which is defined in kernel/softirq.c.
> 
> Signed-off-by: Masami Hiramatsu <mhiramat@...nel.org>
> ---
>  .../ftrace/test.d/ftrace/func_set_ftrace_file.tc   |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> index 113b4d9bc733..20f15c858af6 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> @@ -32,7 +32,7 @@ do_reset
>  
>  FILTER=set_ftrace_filter
>  FUNC1="schedule"
> -FUNC2="do_IRQ"
> +FUNC2="do_softirq"
>  
>  ALL_FUNCS="#### all functions enabled ####"
>  
> 
> 
> 

Looks good to me. I will queue this for 4.15-rc1

thanks,
-- Shuah