lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 1 Nov 2017 13:23:40 +0900 From: Masami Hiramatsu <mhiramat@...nel.org> To: Steven Rostedt <rostedt@...dmis.org> Cc: linux-kselftest@...r.kernel.org, shuah@...nel.org, linux-kernel@...r.kernel.org, Tom Zanussi <tom.zanussi@...ux.intel.com>, Rajvi Jingar <rajvi.jingar@...el.com> Subject: Re: [PATCH] selftests/ftrace: Introduce exit_pass and exit_fail On Tue, 31 Oct 2017 17:44:32 -0400 Steven Rostedt <rostedt@...dmis.org> wrote: > On Tue, 31 Oct 2017 23:51:42 +0900 > Masami Hiramatsu <mhiramat@...nel.org> wrote: > > > diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc b/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc > > index 74507db8bbc8..b8701fa0b8f2 100644 > > --- a/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc > > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc > > @@ -8,7 +8,7 @@ echo > kprobe_events > > echo p:myevent _do_fork > kprobe_events > > test -d events/kprobes/myevent > > echo 1 > events/kprobes/myevent/enable > > -echo > kprobe_events && exit 1 # this must fail > > +echo > kprobe_events && exit_fail > > Should we keep the comment about "this must fail", otherwise it may > look like a mistake. Echoing in kprobe_events returns failure here? Ah, good catch! I misread the comment is for "exit 1"... Thank you, > > -- Steve > > > > echo 0 > events/kprobes/myevent/enable > > echo > kprobe_events # this must succeed > > clear_trace -- Masami Hiramatsu <mhiramat@...nel.org>
Powered by blists - more mailing lists