lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 1 Nov 2017 16:54:04 -0500 From: Rob Herring <robh@...nel.org> To: Joel Stanley <joel@....id.au> Cc: Jonathan Cameron <jic23@...nel.org>, Rick Altherr <raltherr@...gle.com>, Philipp Zabel <philipp.zabel@...il.com>, Hartmut Knaack <knaack.h@....de>, Lars-Peter Clausen <lars@...afoo.de>, Peter Meerwald-Stadler <pmeerw@...erw.net>, linux-iio@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] iio: adc: aspeed: Deassert reset in probe On Tue, Oct 31, 2017 at 12:42:03PM +1030, Joel Stanley wrote: > The ASPEED SoC must deassert a reset in order to use the ADC peripheral. > > The device tree bindings are updated to document the resets phandle, and > the example is updated to match what is expected for both the reset and > clock phandle. Note that the bindings should have always had the reset > controller, as the hardware is unusable without it. > > Signed-off-by: Joel Stanley <joel@....id.au> > --- > v2: > - Ensure disabling path unwinds in opposite order as the enable path > - Note that the bindings were incorrect without the reset phandle, > and for the system to be usable we must update them. No one was > (successfully) using these bindings/driver before without out of tree > hacks in mach-aspeed, as it would not have worked. > > .../devicetree/bindings/iio/adc/aspeed_adc.txt | 4 +++- > drivers/iio/adc/aspeed_adc.c | 25 ++++++++++++++++------ > 2 files changed, 22 insertions(+), 7 deletions(-) Acked-by: Rob Herring <robh@...nel.org>
Powered by blists - more mailing lists