linux-kernel - [PATCH 3.10 024/139] usb: chipidea: debug: check before accessing ci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1509571159-4405-25-git-send-email-w@1wt.eu>
Date:   Wed,  1 Nov 2017 22:17:24 +0100
From:   Willy Tarreau <w@....eu>
To:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        linux@...ck-us.net
Cc:     Michael Thalmeier <michael.thalmeier@...e.at>,
        Peter Chen <peter.chen@....com>, Willy Tarreau <w@....eu>
Subject: [PATCH 3.10 024/139] usb: chipidea: debug: check before accessing ci_role

From: Michael Thalmeier <michael.thalmeier@...e.at>

commit 0340ff83cd4475261e7474033a381bc125b45244 upstream.

ci_role BUGs when the role is >= CI_ROLE_END.

Cc: stable@...r.kernel.org  
Signed-off-by: Michael Thalmeier <michael.thalmeier@...e.at>
Signed-off-by: Peter Chen <peter.chen@....com>
Signed-off-by: Willy Tarreau <w@....eu>
---
 drivers/usb/chipidea/debug.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c
index 36a7063..5a38ca8 100644
--- a/drivers/usb/chipidea/debug.c
+++ b/drivers/usb/chipidea/debug.c
@@ -203,7 +203,8 @@ static int ci_role_show(struct seq_file *s, void *data)
 {
 	struct ci13xxx *ci = s->private;
 
-	seq_printf(s, "%s\n", ci_role(ci)->name);
+	if (ci->role != CI_ROLE_END)
+		seq_printf(s, "%s\n", ci_role(ci)->name);
 
 	return 0;
 }
-- 
2.8.0.rc2.1.gbe9624a