linux-kernel - Re: [PATCH v2 2/2] devicetree: i2c-hid: Add reset property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171101220208.gixv6anohp5q4kh2@rob-hp-laptop>
Date:   Wed, 1 Nov 2017 17:02:08 -0500
From:   Rob Herring <robh@...nel.org>
To:     Lin Huang <hl@...k-chips.com>
Cc:     dmitry.torokhov@...il.com, jikos@...nel.org,
        benjamin.tissoires@...hat.com, jani.nikula@...el.com,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        briannorris@...omium.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/2] devicetree: i2c-hid: Add reset property

On Tue, Oct 31, 2017 at 11:03:16AM +0800, Lin Huang wrote:
> Document a "reset" and "assert-reset-us", it can be used for
> driver control reset property. And reuse post-power-on-delay-ms
> for deassert reset delay.

"dt-bindings: input: " for the subject please.

> 
> Signed-off-by: Lin Huang <hl@...k-chips.com>
> ---
>  Documentation/devicetree/bindings/input/hid-over-i2c.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/input/hid-over-i2c.txt b/Documentation/devicetree/bindings/input/hid-over-i2c.txt
> index 28e8bd8..6ab0eed 100644
> --- a/Documentation/devicetree/bindings/input/hid-over-i2c.txt
> +++ b/Documentation/devicetree/bindings/input/hid-over-i2c.txt
> @@ -31,7 +31,9 @@ device-specific compatible properties, which should be used in addition to the
>  
>  - vdd-supply: phandle of the regulator that provides the supply voltage.
>  - post-power-on-delay-ms: time required by the device after enabling its regulators
> -  before it is ready for communication. Must be used with 'vdd-supply'.
> +  or deassert reset pin before it is ready for communication.
> +- reset: phandle of the gpio that provides for hid reset pin.

The kernel api takes "reset", but the property is "reset-gpios".

And it's not just a phandle typically.

> +- assert-reset-us: the device require reset assert time.
>  
>  Example:
>  
> -- 
> 2.7.4
>