lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 1 Nov 2017 15:21:21 -0700 From: Dave Hansen <dave.hansen@...ux.intel.com> To: Andy Lutomirski <luto@...nel.org>, "Kirill A. Shutemov" <kirill@...temov.name> Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-mm@...ck.org" <linux-mm@...ck.org>, moritz.lipp@...k.tugraz.at, Daniel Gruss <daniel.gruss@...k.tugraz.at>, michael.schwarz@...k.tugraz.at, Linus Torvalds <torvalds@...ux-foundation.org>, Kees Cook <keescook@...gle.com>, Hugh Dickins <hughd@...gle.com>, X86 ML <x86@...nel.org> Subject: Re: [PATCH 04/23] x86, tlb: make CR4-based TLB flushes more robust On 11/01/2017 04:18 AM, Andy Lutomirski wrote: >>> How about just adding a VM_WARN_ON_ONCE, then? >> What's wrong with xor? The function will continue to work this way even if >> CR4.PGE is disabled. > That's true. OTOH, since no one is actually proposing doing that, > there's an argument that people should get warned and therefore be > forced to think about it. What this patch does in the end is make sure that __native_flush_tlb_global_irq_disabled() works, no matter the intiial state of CR4.PGE, *and* it makes it WARN if it gets called in an unexpected initial state (CR4.PGE). That's the best of both worlds IMNHO. Makes people think, and does the right thing no matter what.
Powered by blists - more mailing lists