linux-kernel - Re: [PATCH] ecryptfs: remove unnecessary i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5394f39a-2ae4-0e42-d2a0-bac52fc12352@canonical.com>
Date:   Thu, 2 Nov 2017 17:43:48 -0500
From:   Tyler Hicks <tyhicks@...onical.com>
To:     Jeff Layton <jlayton@...chiereds.net>
Cc:     ecryptfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ecryptfs: remove unnecessary i_version bump

On 10/30/2017 10:03 AM, Jeff Layton wrote:
> On Mon, 2017-10-30 at 11:01 -0400, Jeff Layton wrote:
>> From: Jeff Layton <jlayton@...hat.com>
>>
>> There is no need to bump the i_version counter here, as ecryptfs does
>> not set the MS_I_VERSION flag, and doesn't use it internally. It also
> 
> My apologies, I've been sitting on this patch for a while now. That
> should be changed to the SB_I_VERSION flag. Tyler, do you mind fixing
> that up before merge, or would you like me to resend?

That's no problem. Thanks for the patch! It looks good to me and I'll
take it through my tree.

Tyler

> 
>> only bumps it when the inode is instantiated, which doesn't make much
>> sense.
>>
>> Signed-off-by: Jeff Layton <jlayton@...hat.com>
>> ---
>>  fs/ecryptfs/inode.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
>> index efc2db42d175..b59b083379ea 100644
>> --- a/fs/ecryptfs/inode.c
>> +++ b/fs/ecryptfs/inode.c
>> @@ -64,7 +64,6 @@ static int ecryptfs_inode_set(struct inode *inode, void *opaque)
>>  	/* i_size will be overwritten for encrypted regular files */
>>  	fsstack_copy_inode_size(inode, lower_inode);
>>  	inode->i_ino = lower_inode->i_ino;
>> -	inode->i_version++;
>>  	inode->i_mapping->a_ops = &ecryptfs_aops;
>>  
>>  	if (S_ISLNK(inode->i_mode))
> 




Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)