lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 2 Nov 2017 16:47:56 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Kalle Valo <kvalo@...eaurora.org>,
        Ping-Ke Shih <pkshih@...ltek.com>, devel@...verdev.osuosl.org,
        LKML <linux-kernel@...r.kernel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] staging: rtlwifi: remove an unused variable

On Thu, Nov 2, 2017 at 7:31 AM, Arnd Bergmann <arnd@...db.de> wrote:
> The timer conversion patch left a variable behind, and this
> escaped the build testing:
>
> drivers/staging/rtlwifi/base.c: In function 'rtl_watch_dog_timer_callback':
> drivers/staging/rtlwifi/base.c:2167:23: error: unused variable 'hw' [-Werror=unused-variable]
>
> This removes the stale variable as well.
>
> Fixes: f8af6a323368 ("staging: rtlwifi: Convert timers to use timer_setup()")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/staging/rtlwifi/base.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtlwifi/base.c b/drivers/staging/rtlwifi/base.c
> index 2c693c7aa9d5..c947def37d31 100644
> --- a/drivers/staging/rtlwifi/base.c
> +++ b/drivers/staging/rtlwifi/base.c
> @@ -2164,7 +2164,6 @@ void rtl_watchdog_wq_callback(void *data)
>  void rtl_watch_dog_timer_callback(struct timer_list *t)
>  {
>         struct rtl_priv *rtlpriv = from_timer(rtlpriv, t, works.watchdog_timer);
> -       struct ieee80211_hw *hw = rtlpriv->hw;
>
>         queue_delayed_work(rtlpriv->works.rtl_wq,
>                            &rtlpriv->works.watchdog_wq, 0);
> --
> 2.9.0
>

Acked-by: Kees Cook <keescook@...omium.org>

Thanks for catching this! (sfr reported this too.)

-Kees

-- 
Kees Cook
Pixel Security

Powered by blists - more mailing lists